Skip to content

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-3340

Summary

Bump github.com/klauspost/compress from 1.13.6 to 1.17.2

Background & Motivation

Resolves a goroutine/memory leak when using zstd compression.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days labels Oct 16, 2024
Copy link
Contributor

mongodb-drivers-pr-bot bot commented Oct 16, 2024

API Change Report

./x/mongo/driver/wiremessage

incompatible changes

ReadCompressedCompressedMessage: removed

qingyang-hu
qingyang-hu previously approved these changes Oct 16, 2024
@matthewdale matthewdale force-pushed the godriver3340-upgrade-compress-v1 branch from 47b4ae7 to c7fcda8 Compare October 23, 2024 18:26
@matthewdale matthewdale changed the title GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.17.2 [v1] GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.16.7 [v1] Oct 23, 2024
@matthewdale matthewdale merged commit f8ca5cd into mongodb:v1 Oct 23, 2024
25 of 33 checks passed
@matthewdale
Copy link
Collaborator Author

drivers-pr-bot please backport to release/1.17

mongodb-drivers-pr-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Copy link
Contributor

Sorry, unable to cherry-pick to release/1.17, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout -b cherry-pick-release/1.17-f8ca5cde75866e8ef59bbdaf77dcc13341263885 release/1.17

git fetch origin f8ca5cde75866e8ef59bbdaf77dcc13341263885
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f8ca5cde75866e8ef59bbdaf77dcc13341263885
  1. You will likely have some merge/cherry-pick conflicts here, fix them and commit:
git commit -am {message}
  1. Push to a named branch:
git push origin cherry-pick-release/1.17-f8ca5cde75866e8ef59bbdaf77dcc13341263885
  1. Create a PR against branch release/1.17. I would have named this PR:

"GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.16.7 [v1] (#1869) [release/1.17]"

alcaeus added a commit that referenced this pull request Mar 4, 2025
* commit '0dc2e05e': (184 commits)
  GODRIVER-3448 Limit GOMAXPROCS for fuzz tests (#1939) [v1] (#1943)
  GODRIVER-3470 Correct BSON unmarshaling logic for null values (#1924)
  GODRIVER-3370 Add bypassEmptyTsReplacement option. (#1927)
  BUMP v1.17.2
  GODRIVER-3436 Avoid initializing null data given custom decoder (#1902)
  GODRIVER-3340 Add a test for goroutine leaks. (#1874)
  Update reviewers.txt (#1855) [v1] (#1883)
  Fix data race in 'discard connections' pool test. [v1] (#1877)
  Bump golangci-lint for 1.23 compatibility [v1] (#1875)
  GODRIVER-3340 Bump github.com/klauspost/compress from 1.13.6 to 1.16.7 [v1] (#1869)
  GODRIVER-3374 Add ReadCompressedCompressedMessage back to wiremessage API (#1870)
  GODRIVER-3156 Detect and discard closed idle connections. (#1815)
  GODRIVER-3358 Do not override authSource from TXT record (#1830)
  DEVPROD-10453 Use assume_role for s3 uploads [v1] (#1824)
  GODRIVER-2589 Clarify `*Cursor.All()` behavior in comment. (#1804)
  GODRIVER-3313 Skip CSOT spec tests on Windows and macOS. (#1818)
  BUMP v1.17.0
  GODRIVER-3302 Handle malformatted message length properly. (#1758)
  GODRIVER-3312 Use remaining test secrets from the vault [v1] (#1811)
  Remove GCP from supplied callback example (#1809)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file review-priority-low Low Priority PR for Review: within 3 business days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants